Aaltronav/dougal-software
1
0
Fork 0
mirror of https://gitlab.com/wgp/dougal/software.git synced 2025-12-06 10:17:07 +00:00
Code Issues Packages Projects Releases Activity

Do not store JWT in document.cookie

Browse Source
This commit is contained in:
D. Berge
2025-08-09 12:14:17 +02:00
parent 0b83187372
commit 2c1a24e4a5
2 changed files with 7 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
lib/www/client/source/src/store/modules/user/actions.js
View File

@@ -25,20 +25,22 @@ async function login ({ commit, dispatch }, loginRequest) {
async function logout ({ commit, dispatch }) {
commit('setToken', null);
commit('setUser', null);
commit('setCookie', {value: null});
await dispatch('api', ["/logout"]);
commit('setPreferences', {});
}
function setCookie(context, {name, value, expiry, path}) {
if (!name) name = "JWT";
if (!path) path = "/";
if (!value) value = "";
if (expiry) {
document.cookie = `${name}=${value}; expiry=${(new Date(expiry)).toUTCString()}; path=${path}`;
if (name) {
if (expiry) {
document.cookie = `${name}=${value}; expiry=${(new Date(expiry)).toUTCString()}; path=${path}`;
} else {
document.cookie = `${name}=${value}; path=${path}`;
}
} else {
document.cookie = `${name}=${value}; path=${path}`;
console.warn(`seCookie: You must supply a name`);
}
}
@@ -60,17 +62,6 @@ function setCredentials({ state, commit, getters, dispatch, rootState }, { force
commit('setToken', tokenValue);
commit('setUser', decoded ? new User(decoded, rootState.api.api) : null);
if (tokenValue && decoded) {
if (decoded?.exp) {
dispatch('setCookie', {value: tokenValue, expiry: decoded.exp*1000});
} else {
dispatch('setCookie', {value: tokenValue});
}
} else {
// Clear the cookie
dispatch('setCookie', {value: "", expiry: 0});
}
console.log('Credentials refreshed at', new Date().toISOString());
} else {
console.log('JWT unchanged, skipping update');

6
lib/www/client/source/src/store/modules/user/getters.js
View File

@@ -7,12 +7,6 @@ function jwt (state) {
return state.token;
}
function cookie (state) {
if (state.token) {
return "JWT="+token;
}
}
function preferences (state) {
return state.preferences;
}