Aaltronav/dougal-software
1
0
Fork 0
mirror of https://gitlab.com/wgp/dougal/software.git synced 2025-12-06 09:47:08 +00:00
Code Issues Packages Projects Releases Activity

Only send websocket notifications to authenticated users

Browse Source
This commit is contained in:
D. Berge
2025-08-06 10:40:16 +02:00
parent 9c38af4bc0
commit 36d86c176a
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/www/server/ws/index.js
View File

@@ -28,6 +28,10 @@ function start (server, pingInterval=30000) {
jwt.checkValidCredentials({jwt: token}).then( decoded => { jwt.checkValidCredentials({jwt: token}).then( decoded => {
console.log("refreshJwt decoded JWT = ", decoded); console.log("refreshJwt decoded JWT = ", decoded);
if (decoded) { if (decoded) {
// The connection is now authenticated.
// Let us remember this user's details
socket._jwt = decoded;
console.log("Renewing JWT via websocket"); console.log("Renewing JWT via websocket");
delete decoded.exp; delete decoded.exp;
const token = jwt.issue(decoded); const token = jwt.issue(decoded);
@@ -41,11 +45,13 @@ function start (server, pingInterval=30000) {
scheduleJwtRefresh(token); scheduleJwtRefresh(token);
} else { } else {
console.warn("FAILED to decode JWT"); console.warn("FAILED to decode JWT");
delete socket._jwt;
} }
}) })
.catch( err => { .catch( err => {
console.log("refreshJwt: Invalid credentials found"); console.log("refreshJwt: Invalid credentials found");
console.error(err); console.error(err);
delete socket._jwt;
socket.close(); socket.close();
}); });
} }
@@ -84,7 +90,11 @@ function start (server, pingInterval=30000) {
listen(channels, (data) => { listen(channels, (data) => {
wsServer.clients.forEach( (socket) => { wsServer.clients.forEach( (socket) => {
socket.send(JSON.stringify(data)); if (socket._jwt) {
// Only send notifications to authenticated users
// FIXME should implement authorisation control as in the API
socket.send(JSON.stringify(data));
}
}) })
}); });